feat(telemetry): add IAM telemetry #7830
Open
+51
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
laileni-aws
reviewed
Aug 6, 2025
| if (!AuthUtil.instance.isSsoSession()) { | ||
| telemetry.amazonq_messageResponseError.emit({ | ||
| result: 'Failed', | ||
| cwsprChatConversationType: 'Chat', |
There was a problem hiding this comment.
Can we name this to inlineChat instead of generic Chat ?
There was a problem hiding this comment.
The only reason I didn't change that is in aws-toolkit-common, cwprChatConversationType is defined as such:
{
"name": "cwsprChatConversationType",
"type": "string",
"allowedValues": [
"Chat",
"Assign",
"Transform",
"AgenticChat",
"AgenticChatWithToolUse"
],
"description": "Identifies the type of conversation"
},
Chat might be the most suitable value here. If I can make a PR to change this type in commonDefinition, I will add inlineChat and change the code here as well.
liramon1
force-pushed
the
feature/telemetry
branch
from
6b7a928 to
cd42ede
Compare
…scode into feature/telemetry
yuxianrz
force-pushed
the
feature/telemetry
branch
from
505cd41 to
e68c63c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
IAM credentials does not fit into current SSO telemetry metrics
Solution
Add IAM specific telemetry metric emission.